[dpdk-dev] [PATCH v6 1/2] tools: Add support for handling built-in kernel modules

Kamil Rytarowski krytarowski at caviumnetworks.com
Thu Jan 28 16:33:22 CET 2016

W dniu 28.01.2016 o 14:52, Thomas Monjalon pisze:
> 2016-01-28 12:17, Kamil Rytarowski:
> [...]
>>>> +        # special case for vfio_pci (module is named vfio-pci,
>>>> +        # but its .ko is named vfio_pci)
>>> Isn't it common to have dash replaced by underscore for kernel modules?
>> I retained the logic for special case of vfio-pci. At the moment
>> (according to my knowledge) there are no other DPDK modules with this
>> name replacement.
>> I checked few example Linux modules and if a module is named with dash,
>> it's being replaced to underscore. The modprobe(8) tool can accept both
>> names as interchangeable (with dash and underscore).
>> Would you like to make it a general rule and replace all dashes with
>> underscores?
> I don't know. Do what you think is best.
> Thanks
I suggest to leave it as it is. There is no need to add a layer of 
abstraction for a single known exception.

Also, this is out of scope of my patch.

Thank you.

More information about the dev mailing list