[dpdk-dev] [PATCH v5 09/11] virtio_pci: do not parse if interface is vfio-noiommu

Yuanhan Liu yuanhan.liu at linux.intel.com
Fri Jan 29 08:17:17 CET 2016

Two minor nits.

Firstly about your title, you should be consistent: sometimes you
use virtio_pci, and sometimes you use virtio_pic.h. And for virtio
pmd driver, "virtio: " prefix is pretty enough, no need another
extra "vfio: " or "pci: " prefix.

And the same to your EAL changes. EAL is a bigger, having more
components, thus sometimes 2 prefixs are used. And if you are
not sure how to add prefix, dig the git history to get the answer.

On Tue, Jan 19, 2016 at 05:16:10PM +0530, Santosh Shukla wrote:
> If virtio interface attached to vfio-noiommu driver then
> do not parse for virtio resource. Instead exit with return 0;
> Note: Applicable for virtio spec 0.95.

And this is not necessary: io port stuff is for virtio 0.95 only.
virtio 1.0 won't use that, at all.


More information about the dev mailing list