[dpdk-dev] [PATCH v3] mempool: rename functions with confusing names

Olivier MATZ olivier.matz at 6wind.com
Fri Jul 1 10:57:24 CEST 2016



On 06/30/2016 10:05 PM, Thomas Monjalon wrote:
> 2016-06-30 13:49, Bruce Richardson:
>> The mempool_count and mempool_free_count behaved contrary to what their
>> names suggested. The free_count function actually returned the number of
>> elements that were allocated from the pool, not the number unallocated as
>> the name implied.
>>
>> Fix this by introducing two new functions to replace the old ones,
>> * rte_mempool_avail_count to replace rte_mempool_count
>> * rte_mempool_in_use_count to replace rte_mempool_free_count
>>
>> In this patch, the new functions are added, and the old ones are marked
>> as deprecated. All apps and examples that use the old functions are
>> updated to use the new functions.
> 
> The ThunderX driver uses rte_mempool_count and needs an update.
> Except that, it looks good.
> 

Yep, I don't see any other issue.


More information about the dev mailing list