[dpdk-dev] [PATCH v2 01/16] vfio: fix include of eal_private.h to be local

[Jan Viktorin]

On Mon, 4 Jul 2016 10:22:08 +0000
"Burakov, Anatoly" <anatoly.burakov at intel.com> wrote:

> > -----Original Message-----
> > From: Jan Viktorin [mailto:viktorin at rehivetech.com]
> > Sent: Monday, June 13, 2016 2:02 PM
> > To: dev at dpdk.org
> > Cc: Jan Viktorin <viktorin at rehivetech.com>; Burakov, Anatoly
> > <anatoly.burakov at intel.com>; David Marchand
> > <david.marchand at 6wind.com>; Wiles, Keith <keith.wiles at intel.com>;
> > Santosh Shukla <sshukla at mvista.com>; Stephen Hemminger
> > <stephen at networkplumber.org>; Shreyansh Jain
> > <shreyansh.jain at nxp.com>
> > Subject: [PATCH v2 01/16] vfio: fix include of eal_private.h to be local
> > 
> > Signed-off-by: Jan Viktorin <viktorin at rehivetech.com>
> > ---
> >  lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > index 10266f8..257162b 100644
> > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > @@ -43,11 +43,11 @@
> >  #include <rte_pci.h>
> >  #include <rte_eal_memconfig.h>
> >  #include <rte_malloc.h>
> > -#include <eal_private.h>
> > 
> >  #include "eal_filesystem.h"
> >  #include "eal_pci_init.h"
> >  #include "eal_vfio.h"
> > +#include "eal_private.h"
> > 
> >  /**
> >   * @file
> > --
> > 2.8.0  
> 

Hello Anatoly,

> There's no patch cover letter so I'll reply to the first patch.

yes, there is (and you are in CC), may be lost in the traffic...

http://dpdk.org/ml/archives/dev/2016-June/041085.html

ID: 1465822926-23742-1-git-send-email-viktorin at rehivetech.com

> I've done some cursory testing with a NIC, nothing seems to be broken and the code looks OK to me. So, once this patchset is rebased on latest master (patches 9, 14 and 15 no longer apply cleanly), ack from me.

Thank you very much! I am going to do the rebase.

Jan

> 
> Thanks,
> Anatoly



-- 
   Jan Viktorin                  E-mail: Viktorin at RehiveTech.com
   System Architect              Web:    www.RehiveTech.com
   RehiveTech
   Brno, Czech Republic