[dpdk-dev] [PATCH] net/fm10k: fix RSS hash config

Chen, Jing D jing.d.chen at intel.com
Thu Jul 21 10:48:29 CEST 2016


Hi,

> diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
> index 144b2de..01f4a72 100644
> --- a/drivers/net/fm10k/fm10k_ethdev.c
> +++ b/drivers/net/fm10k/fm10k_ethdev.c
> @@ -2159,8 +2159,8 @@ fm10k_rss_hash_update(struct rte_eth_dev *dev,
> 
>  	PMD_INIT_FUNC_TRACE();
> 
> -	if (rss_conf->rss_key_len < FM10K_RSSRK_SIZE *
> -		FM10K_RSSRK_ENTRIES_PER_REG)
> +	if (key && (rss_conf->rss_key_len < FM10K_RSSRK_SIZE *
> +				FM10K_RSSRK_ENTRIES_PER_REG))
>  		return -EINVAL;
> 
>  	if (hf == 0)

It's also possible that app wants to update rss key and not expect to update hash
function.
Is that indicate we shouldn't return error in case hf == 0?




More information about the dev mailing list