[dpdk-dev] [PATCH v4 1/1] eal: fix resource leak of mapped memory
Sergio Gonzalez Monroy
sergio.gonzalez.monroy at intel.com
Thu Jun 16 14:57:43 CEST 2016
On 15/06/2016 13:25, Marcin Kerlin wrote:
> Patch fixes resource leak in rte_eal_hugepage_attach() where mapped files
> were not freed back to the OS in case of failure. Patch uses the behavior
> of Linux munmap: "It is not an error if the indicated range does not
> contain any mapped pages".
>
> v4:
> 1)removed keyword const from pointer and dependent on that casting (void *)
> v3:
> 1)removed redundant casting
> 2)removed update error message
> v2:
> 1)unmapping also previous addresses
The patch version history should be after the triple dash below so it
won't show up
on git log.
> Coverity issue: 13295, 13296, 13303
> Fixes: af75078fece3 ("first public release")
>
> Signed-off-by: Marcin Kerlin <marcinx.kerlin at intel.com>
> ---
Insert here patch version history.
> lib/librte_eal/linuxapp/eal/eal_memory.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c
> index 79d1d2d..c935765 100644
Thomas, are you ok to update the commit message? Otherwise, please
Mercin do v5 with changes and keep my ack.
Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy at intel.com>
More information about the dev
mailing list