[dpdk-dev] [PATCH v2 3/7] pipeline: fix truncated dependency list

Dumitrescu, Cristian cristian.dumitrescu at intel.com
Mon Jun 27 11:20:50 CEST 2016



> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Sunday, June 26, 2016 5:42 PM
> To: Panu Matilainen <pmatilai at redhat.com>
> Cc: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v2 3/7] pipeline: fix truncated dependency list
> 
> From: Panu Matilainen <pmatilai at redhat.com>
> 
> In other libraries, dependency list is always appended to, but
> in commit 6cbf4f75e059 it with an assignment. This causes the
> librte_eal dependency added in commit 6cbf4f75e059 to get discarded,
> resulting in missing dependency on librte_eal.
> 

Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>


Hi Thomas,

As discussed in some other email thread, it would also make sense to replace the ':=' operator with '+=' operator in Makefile of rte_port and rte_table as well, do you want us to send a separate patch for this?

Thanks,
Cristian



More information about the dev mailing list