[dpdk-dev] [PATCH] ixgbe: fix compilation when offload flags disabled

Bruce Richardson bruce.richardson at intel.com
Wed Jun 29 14:30:17 CEST 2016


On Wed, Jun 29, 2016 at 01:35:15PM +0200, Olivier MATZ wrote:
> 
> 
> On 06/29/2016 12:15 PM, Bruce Richardson wrote:
> >On Mon, Jun 27, 2016 at 07:05:45PM +0200, Thomas Monjalon wrote:
> >>2016-06-27 17:44, Olivier Matz:
> >>>The ixgbe driver does not compile if CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=n
> >>>because the macro has not the proper number of parameters.
> >>
> >>We really need to understand why this build option is needed.
> >>Target: zero build option.
> >
> >Agreed. However, we are where we are right now, and this build option is there.
> >
> >Olivier, can you do a V2 of this patch based on dpdk-next-net/rel_16_07, since
> >the code in question has actually moved on that branch.
> 
> Sure, will do.
> 
Thanks.

> 
> >Out of interest, can you perhaps also give a little more detail on how to
> >reproduce the issue, as turning off the setting fails to show up a build
> >problem for me with either gcc or clang, at -O3 or -O0.
> 
> That's strange, I just set CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=n to
> reproduce the issue. I'll check on dpdk-next-net/rel_16_07 and add more
> details, like the output of the compiler.
> 
Ok, no problem either way since inspection of the code shows there is a bug
there anyway. I'm just curious as to why I couldn't reproduce it.

/Bruce


More information about the dev mailing list