[dpdk-dev] [PATCH v1 1/1] examples/bond: fix unchecked return value

Declan Doherty declan.doherty at intel.com
Thu Jun 30 11:13:48 CEST 2016


On 29/06/16 10:23, ptazarex at ecsmtp.igk.intel.com wrote:
> The example is calling rte_eal_wait_lcore without checking return value.
> Now it is fixed by checking the value and print proper message.
>
> Coverity issue: 37789
> Coverity issue: 37790
> Fixes: cc7e8ae84faa ("examples/bond: add example application for link bonding mode 6")
>
> Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz at intel.com>
> ---
>  examples/bond/main.c |   24 ++++++++++++++++--------
>  1 file changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/examples/bond/main.c b/examples/bond/main.c
> index 53bd044..776fad0 100644
> --- a/examples/bond/main.c
> +++ b/examples/bond/main.c
> @@ -590,10 +590,14 @@ static void cmd_stop_parsed(__attribute__((unused)) void *parsed_result,
>  		return;
>  	}
>  	global_flag_stru_p->LcoreMainIsRunning = 0;
> -	rte_eal_wait_lcore(global_flag_stru_p->LcoreMainCore);
> -	cmdline_printf(cl,
> -			"lcore_main stopped on core:%d\n",
> -			global_flag_stru_p->LcoreMainCore);
> +	if (rte_eal_wait_lcore(global_flag_stru_p->LcoreMainCore) < 0)
> +		cmdline_printf(cl,
> +				"error: lcore_main can not stop on core:%d\n",
> +				global_flag_stru_p->LcoreMainCore);
> +	else
> +		cmdline_printf(cl,
> +				"lcore_main stopped on core:%d\n",
> +				global_flag_stru_p->LcoreMainCore);
>  	rte_spinlock_unlock(&global_flag_stru_p->lock);
>  }
>
> @@ -628,10 +632,14 @@ static void cmd_quit_parsed(__attribute__((unused)) void *parsed_result,
>  		return;
>  	}
>  	global_flag_stru_p->LcoreMainIsRunning = 0;
> -	rte_eal_wait_lcore(global_flag_stru_p->LcoreMainCore);
> -	cmdline_printf(cl,
> -			"lcore_main stopped on core:%d\n",
> -			global_flag_stru_p->LcoreMainCore);
> +	if (rte_eal_wait_lcore(global_flag_stru_p->LcoreMainCore) < 0)
> +		cmdline_printf(cl,
> +				"error: lcore_main can not stop on core:%d\n",
> +				global_flag_stru_p->LcoreMainCore);
> +	else
> +		cmdline_printf(cl,
> +				"lcore_main stopped on core:%d\n",
> +				global_flag_stru_p->LcoreMainCore);
>  	rte_spinlock_unlock(&global_flag_stru_p->lock);
>  	cmdline_quit(cl);
>  }
>

Acked-by: Declan Doherty <declan.doherty at intel.com>


More information about the dev mailing list