[dpdk-dev] [PATCH] config: remove duplicate configuration information

[Traynor, Kevin]

> -----Original Message-----
> From: Panu Matilainen [mailto:pmatilai at redhat.com]
> Sent: Friday, March 4, 2016 9:39 AM
> To: Traynor, Kevin <kevin.traynor at intel.com>; Thomas Monjalon
> <thomas.monjalon at 6wind.com>; Wiles, Keith <keith.wiles at intel.com>
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration
> information
> 
> On 03/04/2016 11:28 AM, Traynor, Kevin wrote:
> >
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> >> Sent: Thursday, March 3, 2016 6:38 PM
> >> To: Wiles, Keith <keith.wiles at intel.com>
> >> Cc: dev at dpdk.org
> >> Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration
> >> information
> >>
> >> 2016-02-22 07:53, Keith Wiles:
> >>> --- /dev/null
> >>> +++ b/config/common_base
> >>> +CONFIG_RTE_EAL_IGB_UIO=y
> >>> +CONFIG_RTE_EAL_VFIO=y
> >>
> >> These options should be disabled in the base file
> >> and enabled in Linux.
>     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> >>
> >>> +CONFIG_RTE_LIBRTE_PMD_AF_PACKET=y
> >>
> >> Idem, it should be disabled.
> >>
> >>> +CONFIG_RTE_LIBRTE_POWER=y
> >>
> >> Idem?
> >>
> >>> +CONFIG_RTE_LIBRTE_KNI=y
> >>
> >> Should be disabled.
> >>
> >>> +CONFIG_RTE_LIBRTE_VHOST=y
> >>
> >> Should be disabled.
> >
> > Any reason this should be disabled? It was changed to =Y in DPDK 2.1.
> 
> That's what I first thought too, but I think Thomas meant "disable in
> common_base, enable in Linux config" for all these.
> 
> 	- Panu -

Ah, ok - got it, that makes sense. thanks.