[dpdk-dev] [PATCH] lpm: merge tbl24 and tbl8 structures

Kobylinski, MichalX michalx.kobylinski at intel.com
Fri Mar 4 16:11:01 CET 2016



> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com]
> Sent: Friday, March 4, 2016 4:04 PM
> To: Thomas Monjalon <thomas.monjalon at 6wind.com>
> Cc: Richardson, Bruce <bruce.richardson at intel.com>; dev at dpdk.org;
> Kobylinski, MichalX <michalx.kobylinski at intel.com>
> Subject: Re: [dpdk-dev] [PATCH] lpm: merge tbl24 and tbl8 structures
> Importance: High
> 
> On Fri, Mar 04, 2016 at 03:57:43PM +0100, Thomas Monjalon wrote:
> > 2015-11-24 14:25, Bruce Richardson:
> > > The tbl8 and tbl24 structures were essentially identical except for
> > > slightly different names for one or two fields. Merge these two
> > > structures into a single structure definition.
> > >
> > > Two fields have been renamed as part of this change: the "ext_entry"
> > > field in the tbl24 has been renamed to "valid_group" to match the
> > > tbl8 value to make the merge easier, and the "tbl8_gindex" field has
> > > been renamed to "group_idx". The "valid_group" field now serves two
> > > purposes: in a tbl8 it indicates if the group, i.e. the tbl8, is
> > > valid, and in a tbl24, it indicates if the "group_idx" is valid,
> > > i.e. whether the value is a next_hop or a tbl8 index. [The name
> > > "group_idx" was used to make this latter link between the fields
> > > clearer]
> > >
> > > Suggested-by: Vladimir Medvedkin <medvedkinv at gmail.com>
> > > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> >
> > This patch was forgotten.
> > Michal, Jerin, maybe you'll have to rebase on top of it.

ok, I'll rebase on top of it.
> 
> I wait for Michal to send the next version. I will the v5 rebased on Michal patch.
> 
> Jerin
> 
> >
> > Applied, thanks


More information about the dev mailing list