[dpdk-dev] [PATCH v4] eal: add function to check if primary proc alive

[Thomas Monjalon]

I'm looking into details...

2016-02-23 14:10, Harry van Haaren:
>  EAL
>  ~~~
>  
> +* **Added rte_eal_primary_proc_alive() function**
> +
> +  A new function ``rte_eal_primary_proc_alive()`` has been added
> +  to allow the user to detect if a primary process is running.
> +  Use cases for this feature include fault detection, and monitoring
> +  using secondary processes.
>  

A space is missing here (2 lines before next title).

>  Drivers
>  ~~~~~~~
[...]
> + *   Copyright 2016 Intel Shannon Ltd. All rights reserved.

I had not noticed before. Intel Shannon Ltd is a separate entity?

[...]
> + * @return
> + *  - If alive, returns one.
> + *  - If dead, returns zero.

Why not use digits?

> + */
> +int rte_eal_primary_proc_alive(const char *config_file_path);
> +
> +

The functions are usually separated by only 1 line,
except in keepalive for an unknown reason.