[dpdk-dev] [PATCH v3 00/18] fm10k: update shared code

[Chen, Jing D]

Hi, Xiao

> -----Original Message-----
> From: Wang, Xiao W
> Sent: Tuesday, March 8, 2016 8:15 AM
> To: Richardson, Bruce <bruce.richardson at intel.com>; Chen, Jing D
> <jing.d.chen at intel.com>
> Cc: Chen, Jing D <jing.d.chen at intel.com>; dev at dpdk.org; He, Shaopeng
> <shaopeng.he at intel.com>
> Subject: RE: [PATCH v3 00/18] fm10k: update shared code
> 
> 
> 
> > -----Original Message-----
> > From: Richardson, Bruce
> > Sent: Tuesday, March 8, 2016 9:24 PM
> > To: Wang, Xiao W <xiao.w.wang at intel.com>; Chen, Jing D
> > <jing.d.chen at intel.com>
> > Cc: Chen, Jing D <jing.d.chen at intel.com>; dev at dpdk.org; He, Shaopeng
> > <shaopeng.he at intel.com>
> > Subject: Re: [PATCH v3 00/18] fm10k: update shared code
> >
> > On Fri, Feb 19, 2016 at 07:06:47PM +0800, Wang Xiao W wrote:
> > > v3:
> > > * Fixed checkpatch.pl warning about long commit message.
> > > * Fixed the issue of compile failure about part of patches applied.
> > > * Split the misc-small-fixes patch into several patches.
> > >
> > > v2:
> > > * Put the two extra fix patches ahead of the base code patches.
> > >
> > > This patch set has passed regression test.
> > >
> > > Wang Xiao W (18):
> > >   fm10k: use default mailbox message handler for PF
> > >   fm10k/base: correct typecast in fm10k_update_xc_addr_pf
> > >   fm10k/base: cleanup namespace pollution
> > >   fm10k/base: use bitshift for itr_scale
> > >   fm10k/base: reset max_queues on init_hw_vf failure
> > >   fm10k/base: document ITR scale workaround in VF TDLEN register
> > >   fm10k/base: cleanup lines over 80 characters
> > >   fm10k/base: cleanup useless else
> > >   fm10k/base: use BIT macro instead of open-coded bit-shifting of 1
> > >   fm10k/base: do not use CamelCase
> > >   fm10k/base: use memcpy for mac addr copy
> > >   fm10k/base: allow removal of is_slot_appropriate function
> > >   fm10k/base: consistently use VLAN ID when referencing vid variables
> > >   fm10k/base: imporve comment per upstream review changes
> > >   fm10k/base: fix TLV structures alignment
> > >   fm10k/base: move constants to the right of binary operators
> > >   fm10k/base: minor cleanups
> > >   fm10k/base: remove unused struct element
> > >
> > >  drivers/net/fm10k/base/fm10k_api.c   |   2 +
> > >  drivers/net/fm10k/base/fm10k_api.h   |   2 +
> > >  drivers/net/fm10k/base/fm10k_mbx.c   |  63 +++++++-----
> > >  drivers/net/fm10k/base/fm10k_mbx.h   |  11 +--
> > >  drivers/net/fm10k/base/fm10k_osdep.h |  32 ++++++
> > >  drivers/net/fm10k/base/fm10k_pf.c    |  88 +++++++++--------
> > >  drivers/net/fm10k/base/fm10k_pf.h    |  18 ++--
> > >  drivers/net/fm10k/base/fm10k_tlv.c   |  40 ++++----
> > >  drivers/net/fm10k/base/fm10k_tlv.h   |   9 +-
> > >  drivers/net/fm10k/base/fm10k_type.h  | 182 +++++++---------------------
> -------
> > >  drivers/net/fm10k/base/fm10k_vf.c    |  32 ++++--
> > >  drivers/net/fm10k/fm10k_ethdev.c     |  41 +++-----
> > >  12 files changed, 222 insertions(+), 298 deletions(-)
> > >
> > > --
> > > 1.9.3
> > >
> > Hi Mark,
> >
> > Can we get fm10k maintainer review and/or ack on this patchset please.
> >
> > Thanks,
> > /Bruce
> 
> Hi Bruce,
> 
> Mark has reviewed and acked the patch set in v2, and I put the "Acked-by "
> in the v3 01/18 patch.
> It's the same for my FTAG patch.
> 

It's better to add acked-by in both patch set and cover letter, this may be more
helpful for maintainers. 

> Best Regards,
> Xiao