[dpdk-dev] [PATCH] eal_interrupts.c: properly init struct epoll_event (valgrind)

Matthew Hall mhall at mhcomputing.net
Fri Mar 18 00:00:55 CET 2016


On Thu, Mar 17, 2016 at 10:19:24AM -0700, Stephen Hemminger wrote:
> > > A better patch would be to move the data structure into the
> > > code block used, and get rid of the useless else (rte_panic never returns);
> > > and fix the indentation, and use C99 initialization which should make valgrind
> > > happier.
> > > 
> > > The moral is don't just slap memsets around

Hi guys,

As you probably read before, I am a security developer, not a low-level / 
kernel guy, and my DPDK work is spare time only. So I try to limit the scope 
of my DPDK patches where possible, to avoid making headaches for the full-time 
team to the minimum required. I can try to redo or refactor all this unrelated 
stuff in the code, but I wouldn't be as fast or accurate as you would.

Matthew.


More information about the dev mailing list