[dpdk-dev] [PATCH] testpmd: fix build on FreeBSD
Bruce Richardson
bruce.richardson at intel.com
Mon Mar 21 15:57:33 CET 2016
On Mon, Mar 21, 2016 at 09:40:07AM +0000, De Lara Guarch, Pablo wrote:
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez
> > Monroy
> > Sent: Monday, March 21, 2016 9:13 AM
> > To: Liu, Yong; dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] testpmd: fix build on FreeBSD
> >
> > On 21/03/2016 01:44, Marvin Liu wrote:
> > > Build log:
> > > /root/dpdk/app/test-pmd/cmdline.c:6687:45: error: no member named
> > > 's6_addr32' in 'struct in6_addr'
> > > rte_be_to_cpu_32(res->ip_value.addr.ipv6.s6_addr32[i]);
> > >
> > > This is caused by macro "s6_addr32" not defined on FreeBSD.
> > >
> > > Signed-off-by: Marvin Liu <yong.liu at intel.com>
> > >
> > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> > > index 9d52b8c..51ad23b 100644
> > > --- a/app/test-pmd/cmdline.c
> > > +++ b/app/test-pmd/cmdline.c
> > > @@ -6684,7 +6684,11 @@ cmd_tunnel_filter_parsed(void *parsed_result,
> > > int i;
> > > for (i = 0; i < 4; i++) {
> > > tunnel_filter_conf.ip_addr.ipv6_addr[i] =
> > > +#ifdef RTE_EXEC_ENV_BSDAPP
> > > + rte_be_to_cpu_32(res-
> > >ip_value.addr.ipv6.__u6_addr.__u6_addr32[i]);
> > > +#else
> > > rte_be_to_cpu_32(res-
> > >ip_value.addr.ipv6.s6_addr32[i]);
> > > +#endif
> >
> > Why not always use .__u6_addr.__u6_addr32[i] and avoid ifdef?
> >
> > Sergio
> >
> > > }
> > > tunnel_filter_conf.ip_type = RTE_TUNNEL_IPTYPE_IPV6;
> > > }
>
> Also, can you include the missing "Fixes" line?
>
A slightly higher level question:
Why are we doing 32-bit endian conversions, when IPv6 addresses are normally
specified in 16-bit (4-hex digit) blocks?
/Bruce
More information about the dev
mailing list