[dpdk-dev] [PATCH] ethdev: don't count missed packets in erroneous packets counter

Thomas Monjalon thomas.monjalon at 6wind.com
Tue Mar 22 11:06:05 CET 2016


2016-03-17 17:40, Thomas Monjalon:
> CC Maryam and Olivier who had discussions about imissed and other stats:
> 	http://dpdk.org/ml/archives/dev/2015-August/022905.html
> 	http://dpdk.org/ml/archives/dev/2015-September/023351.html
> 	http://dpdk.org/ml/archives/dev/2015-September/023612.html
> 
> 2016-03-10 16:03, Igor Ryzhov:
> > Comment for "ierrors" counter says that it counts erroneous received packets. But for some reason "imissed" counter is added to "ierrors" counter in most drivers. It is a mistake, because missed packets are obviously not received. This patch fixes it.
> 
> According to this patch
> 	http://dpdk.org/browse/dpdk/commit/?id=70bdb186
> imissed was kept in ierrors because of backward compatibility.
> I'm OK to remove imissed from ierrors.
> 
> Fixes: 70bdb18657da ("ethdev: add Rx error counters for missed, badcrc and badlen packets")
> Fixes: 6bfe648406b5 ("i40e: add Rx error statistics")
> Fixes: 856505d303f4 ("cxgbe: add port statistics")
> 
> Acked-by: Thomas Monjalon <thomas.monjalon at 6wind.com>

Applied, thanks


More information about the dev mailing list