[dpdk-dev] [PATCH v3] eal: make hugetlb initialization more robust

Sergio Gonzalez Monroy sergio.gonzalez.monroy at intel.com
Tue May 10 10:54:33 CEST 2016


Hi Jianfeng,

On 09/05/2016 11:48, Jianfeng Tan wrote:

>   		/* find physical addresses and sockets for each hugepage */
> @@ -1172,8 +1255,9 @@ rte_eal_hugepage_init(void)
>   		hp_offset += new_pages_count[i];
>   #else
>   		/* remap all hugepages */
> -		if (map_all_hugepages(&tmp_hp[hp_offset], hpi, 0) < 0){
> -			RTE_LOG(DEBUG, EAL, "Failed to remap %u MB pages\n",
> +		if ((uint32_t)map_all_hugepages(&tmp_hp[hp_offset], hpi, 0) !=
> +		    hpi->num_pages[0]) {

It probably makes more sense to have map_all_hugepages return uint32_t 
instead.

Sergio



More information about the dev mailing list