[dpdk-dev] [PATCH 01/20] thunderx/nicvf/base: add hardware API for ThunderX nicvf inbuilt NIC

[Pattan, Reshma]

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob
> Sent: Saturday, May 7, 2016 4:16 PM
> To: dev at dpdk.org
> Cc: thomas.monjalon at 6wind.com; Richardson, Bruce
> <bruce.richardson at intel.com>; Jerin Jacob
> <jerin.jacob at caviumnetworks.com>; Maciej Czekaj
> <maciej.czekaj at caviumnetworks.com>; Kamil Rytarowski
> <Kamil.Rytarowski at caviumnetworks.com>; Zyta Szpak
> <zyta.szpak at semihalf.com>; Slawomir Rosek <slawomir.rosek at semihalf.com>;
> Radoslaw Biernacki <rad at semihalf.com>
> Subject: [dpdk-dev] [PATCH 01/20] thunderx/nicvf/base: add hardware API for
> ThunderX nicvf inbuilt NIC
> 
> +int
> +nicvf_reg_poll_interrupts(struct nicvf *nic)
> +{
> +	int msg = 0;
> +	uint64_t intr;
> +
> +	intr = nicvf_reg_read(nic, NIC_VF_INT);
> +	if (intr & NICVF_INTR_MBOX_MASK) {
> +		nicvf_reg_write(nic, NIC_VF_INT, NICVF_INTR_MBOX_MASK);
> +		msg = nicvf_handle_mbx_intr(nic);
> +	}
> +	if (intr & NICVF_INTR_QS_ERR_MASK) {
> +		nicvf_reg_write(nic, NIC_VF_INT, NICVF_INTR_QS_ERR_MASK);
> +		nicvf_handle_qset_err_intr(nic);
> +	}
> +	return msg;
> +}
> +
> +
[Reshma]: Multiple blank lines

> +int
> +nicvf_qset_rbdr_reclaim(struct nicvf *nic, uint16_t qidx)
> +{
> +	uint64_t status;
> +	int timeout = 10;
> +	struct nicvf_rbdr *rbdr = nic->rbdr;
> +
> +	/* Save head and tail pointers for freeing up buffers */
> +	if (rbdr) {
> +		rbdr->head = nicvf_queue_reg_read(nic,
> +					  NIC_QSET_RBDR_0_1_HEAD,
> +					  qidx) >> 3;
> +		rbdr->tail = nicvf_queue_reg_read(nic,
> +					  NIC_QSET_RBDR_0_1_TAIL,
> +					  qidx) >> 3;

 [Reshma]: Mix of tabs + spaces, u can use all tabs, U can correct this for other parts of  the file and other files too. 

Thanks,
Reshma