[dpdk-dev] [PATCH] examples/ip_pipline: fix memory initialization in firewall bulk functions

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Mrzyglod, DanielX T
> Sent: Friday, May 6, 2016 6:55 PM
> To: Kerlin, MarcinX <marcinx.kerlin at intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu at intel.com>; Singh, Jasvinder
> <jasvinder.singh at intel.com>
> Cc: dev at dpdk.org; Mrzyglod, DanielX T <danielx.t.mrzyglod at intel.com>
> Subject: [PATCH] examples/ip_pipline: fix memory initialization in firewall
> bulk functions
> 
> bulk functions expect that all memory is set with zeros
> 
> Fixes: 67ebdbef0c31 ("examples/ip_pipeline: add bulk update of firewall
> rules")
> 
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod at intel.com>
> ---
>  examples/ip_pipeline/pipeline/pipeline_firewall_be.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/examples/ip_pipeline/pipeline/pipeline_firewall_be.c
> b/examples/ip_pipeline/pipeline/pipeline_firewall_be.c
> index e7a8a4c..4edca66 100644
> --- a/examples/ip_pipeline/pipeline/pipeline_firewall_be.c
> +++ b/examples/ip_pipeline/pipeline/pipeline_firewall_be.c
> @@ -732,7 +732,7 @@ pipeline_firewall_msg_req_add_bulk_handler(struct
> pipeline *p, void *msg)
>  	n_keys = req->n_keys;
> 
>  	for (i = 0; i < n_keys; i++) {
> -		entries[i] = rte_malloc(NULL,
> +		entries[i] = rte_zmalloc(NULL,
>  				sizeof(struct firewall_table_entry),
>  				RTE_CACHE_LINE_SIZE);
>  		if (entries[i] == NULL) {
> @@ -740,7 +740,7 @@ pipeline_firewall_msg_req_add_bulk_handler(struct
> pipeline *p, void *msg)
>  			return rsp;
>  		}
> 
> -		params[i] = rte_malloc(NULL,
> +		params[i] = rte_zmalloc(NULL,
>  				sizeof(struct
> rte_table_acl_rule_add_params),
>  				RTE_CACHE_LINE_SIZE);
>  		if (params[i] == NULL) {
> @@ -814,7 +814,7 @@ pipeline_firewall_msg_req_del_bulk_handler(struct
> pipeline *p, void *msg)
>  	n_keys = req->n_keys;
> 
>  	for (i = 0; i < n_keys; i++) {
> -		params[i] = rte_malloc(NULL,
> +		params[i] = rte_zmalloc(NULL,
>  				sizeof(struct
> rte_table_acl_rule_delete_params),
>  				RTE_CACHE_LINE_SIZE);
>  		if (params[i] == NULL) {
> --
> 2.5.5


Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>