[dpdk-dev] [PATCH v2 02/40] bnxt: add HWRM init code

Stephen Hurd stephen.hurd at broadcom.com
Thu May 26 01:35:27 CEST 2016


On Wed, May 25, 2016 at 8:05 AM, Bruce Richardson <
bruce.richardson at intel.com> wrote:

>
> Checkpatch also highlights a few minor issues that might be worth
> addressing.
>
>   CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
>   #137: FILE: drivers/net/bnxt/bnxt.h:94:
>   +#define BNXT_FLAG_VF           (1<<1)
>                                   ^
>
>   WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
>   #259: FILE: drivers/net/bnxt/bnxt_ethdev.c:143:
>   +       /*
>   +       eth_dev->rx_pkt_burst = &bnxt_recv_pkts;
>
>   WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
>   #366: FILE: drivers/net/bnxt/bnxt_hwrm.c:56:
>   +       unsigned i;
>
>
What version of checkpatch.pl should we be using?  These were not found by
the one I had.

-- 
Stephen Hurd


More information about the dev mailing list