[dpdk-dev] [PATCH 3/3] vhost: update comments

Mcnamara, John john.mcnamara at intel.com
Fri Nov 4 14:28:45 CET 2016



> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Wednesday, November 2, 2016 3:15 AM
> To: dev at dpdk.org
> Cc: Mcnamara, John <john.mcnamara at intel.com>; Yuanhan Liu
> <yuanhan.liu at linux.intel.com>
> Subject: [PATCH 3/3] vhost: update comments
> 
> vhost-cuse is removed, update corresponding comments that are still
> referencing it.
> 
> Signed-off-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>
>
> ...
>
>  /*
> - * Backend-specific cleanup. Defined by vhost-cuse and vhost-user.
> + * Backend-specific cleanup.
> + *
> + * TODO: fix it; we have one backend now
>   */
>  void vhost_backend_cleanup(struct virtio_net *dev);

In general it is not a good idea to leave TODOs/Fixmes around unless they
that a better explanation of why they are there.

Apart from that:


Acked-by: John McNamara <john.mcnamara at intel.com>




More information about the dev mailing list