[dpdk-dev] [PATCH v2] eal/linuxapp: fix return value check of mknod()
wei.dai at intel.com
Wed Nov 16 16:18:46 CET 2016
Thanks to David, I will submit v3 patch to indicate correct Fixes.
> -----Original Message-----
> From: David Marchand [mailto:david.marchand at 6wind.com]
> Sent: Wednesday, November 16, 2016 7:24 PM
> To: Dai, Wei <wei.dai at intel.com>
> Cc: dev at dpdk.org; Burakov, Anatoly <anatoly.burakov at intel.com>
> Subject: Re: [PATCH v2] eal/linuxapp: fix return value check of mknod()
> Hello Wei,
> On Wed, Nov 16, 2016 at 3:40 AM, Wei Dai <wei.dai at intel.com> wrote:
> > In function pci_mknod_uio_dev() in lib/librte_eal/eal/eal_pci_uio.c,
> > The return value of mknod() is ret, not f got by fopen().
> > So the value of ret should be checked for mknod().
> > Fixes: 67c536bdad93 ("pci: move uio mapping in a dedicated file")
> The commit you are pointing is just moving the code.
> I would incriminate f7f97c16048e ("pci: add option --create-uio-dev to run
> without hotplug")
> The rest looks good to me.
> David Marchand
More information about the dev