[dpdk-dev] [PATCH] lib/librte_mempool: a redundant of socket_id assignment

Olivier Matz olivier.matz at 6wind.com
Fri Nov 18 15:07:47 CET 2016

Hi Wei,

On 11/14/2016 11:25 AM, Mcnamara, John wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wei Zhao
>> Sent: Monday, November 14, 2016 2:16 AM
>> To: dev at dpdk.org
>> Cc: olivier.matz at 6wind.com; Zhao1, Wei <wei.zhao1 at intel.com>
>> Subject: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant of socket_id
>> assignment
>> From: zhao wei <wei.zhao1 at intel.com>
>> There is a redundant repetition mempool socket_id assignment in the file
>> rte_mempool.c in function rte_mempool_create_empty.The statement "mp-
>>> socket_id = socket_id;"appear twice in line 821 and 824.One of them is
>> redundant, so delete it.
>> Fixes: 85226f9c526b ("lib/librte_mempool:  mempool:introduce a function to
>> create an empty pool")
>> Signed-off-by: zhao wei <wei.zhao1 at intel.com>
> Titles should generally start with a verb to indicate what is being done.
> Something like:
>     lib/librte_mempool: remove redundant socket_id assignment
> Apart from that. 
> Acked-by: John McNamara <john.mcnamara at intel.com>

I would even say:
  mempool: remove redundant socket_id assignment

Acked-by: Olivier Matz <olivier.matz at 6wind.com>

More information about the dev mailing list