[dpdk-dev] [PATCH] crypto: remove unused digest-appended feature

John Griffin john.griffin at intel.com
Fri Nov 18 19:15:59 CET 2016

On 17/11/16 17:33, Fiona Trahe wrote:
> The cryptodev API had specified that if the digest address field was
> left empty on an authentication operation, then the PMD would assume
> the digest was appended to the source or destination data.
> This case was not handled at all by most PMDs and incorrectly handled
> by the QAT PMD.
> As no bugs were raised, it is assumed to be not needed, so this patch
> removes it, rather than add handling for the case on all PMDs.
> The digest can still be appended to the data, but its
> address must now be provided in the op.
> Signed-off-by: Fiona Trahe <fiona.trahe at intel.com>
> ---
>   drivers/crypto/qat/qat_adf/qat_algs_build_desc.c |  2 ++
>   drivers/crypto/qat/qat_crypto.c                  | 18 +-----------------
>   lib/librte_cryptodev/rte_crypto_sym.h            | 10 +---------
>   3 files changed, 4 insertions(+), 26 deletions(-)

Acked-by: John Griffin <john.griffin at intel.com>

More information about the dev mailing list