[dpdk-dev] [PATCH 2/4] eventdev: implement the northbound APIs

Thomas Monjalon thomas.monjalon at 6wind.com
Wed Nov 23 20:18:09 CET 2016

2016-11-18 11:15, Jerin Jacob:
> This patch set defines the southbound driver interface
> and implements the common code required for northbound
> eventdev API interface.

Please make two separate patches.

> +#define RTE_PMD_DEBUG_TRACE(...) \
> +	rte_pmd_debug_trace(__func__, __VA_ARGS__)
> +#else
> +#define RTE_PMD_DEBUG_TRACE(...)
> +#endif

I would like to discuss the need for a debug option as there is
already a log level.

> +/* Logging Macros */
> +#define EDEV_LOG_ERR(fmt, args...) \

Every symbols and macros in an exported header must be prefixed by RTE_.

> +/* Macros to check for valid device */
> +#define RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, retval) do { \

Sometimes you use RTE_EVENT_DEV_ and sometimes RTE_EVENTDEV.
(I prefer the latter).

> +struct rte_eventdev_driver {
> +	struct rte_pci_driver pci_drv;	/**< The PMD is also a PCI driver. */

It must not be directly linked to the underlying bus.

More information about the dev mailing list