[dpdk-dev] [PATCH] scripts: fix checkpatch from standard input
olivier.matz at 6wind.com
Mon Nov 28 16:21:10 CET 2016
On Mon, 21 Nov 2016 23:42:41 +0100, Thomas Monjalon
<thomas.monjalon at 6wind.com> wrote:
> When checking a valid patch from standard input,
> the footer lines of the report are not filtered out.
> The function check is called outside of any loop,
> so the statement continue has no effect and the footer is printed.
> Fixes: 8005feef421d ("scripts: add standard input to checkpatch")
> Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
The 'continue' statement is not always without effect. On my machine
(but it looks it's not the same everywhere):
- with dash, the 'continue' acts like a return in that case
- with bash, it displays an error:
"continue: only meaningful in a `for', `while', or `until' loop"
- with bash --posix, the 'continue' is ignored...
In my case, checkpatches.sh was displaying "0/1 valid" although there
was no error. This patch solves the issue, thanks.
Acked-by: Olivier Matz <olivier.matz at 6wind.com>
More information about the dev