[dpdk-dev] [PATCH v2 04/22] qede/base: update base driver

[Thomas Monjalon]

2016-09-30 18:40, Mody, Rasesh:
> > From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
> > Thank you for the update, base driver patch update now reduced from
> > "14653 insertions(+), 8536 deletions(-)" to
> > "10857 insertions(+), 4853 deletions(-)"
> > 
> > But this is still to big for reviewing, specially there are some low hanging fruits
> > for cleanup, like big chunk of comment updates or whitespace updates or
> > non base driver codes in the patch.
> > 
> > If the expectation is that somebody non maintainer review the code,
> > understand it and highlight any possible defects, I believe this patch is too big
> > and needs to be split more into logical pieces, but since this is a driver code
> > and a little special, and it may not be possible to completely understand the
> > code without knowing underlying hardware, I am not sure how to proceed
> > and adding Bruce and Thomas to cc for guidance.

As you said it makes contribution really hard.
So it is missing the point of sharing its source code in Open Source.

> This 8.10.x.x base driver is a common code shared by multiple drivers. It has gone through extensive testing.
> We have split the base driver patch into smaller logical patches. It would be difficult to split this patch further.

Please check how Intel updates its base drivers and try harder.
We all know it requires some time, but it provides a valuable knowledge base.
Thanks