[dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL

Shreyansh Jain shreyansh.jain at nxp.com
Sat Oct 8 14:47:59 CEST 2016



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, October 07, 2016 7:15 PM
> To: Shreyansh Jain <shreyansh.jain at nxp.com>
> Cc: david.marchand at 6wind.com; dev at dpdk.org
> Subject: Re: [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL
> 
> 2016-10-07 19:03, Shreyansh Jain:
> > DRIVER_REGISTER_PCI -> EAL_REGISTER_PCI
> > DRIVER_REGISTER_PCI_TABLE -> EAL_REGISTER_PCI_TABLE
> 
> Why not RTE_ prefix instead of EAL_?

Because while searching for similar naming pattern I came across other macros like EAL_REGISTER_TAILQ which were within librte_eal/eal/* folders.

> Why 3 patches? As there is no specific comment in each, I think you can
> squash.

Because each of the patch are common and tightly related changes. The replacement touches a large number of files, even though the change itself is small. By splitting, it makes review (or minor misses) easier - at least for me.
Anyways, if as a maintainer you prefer having a single bulk, I have no issues.

I will send next version with RTE_* and the 'grep -E' suggestion from Neil.

-
Shreyansh


More information about the dev mailing list