[dpdk-dev] [PATCH v3 03/16] mbuf: move packet type definitions in a new file

[Thomas Monjalon]

2016-10-11 11:01, Olivier MATZ:
> Hi Thomas,
> 
> On 10/10/2016 04:52 PM, Thomas Monjalon wrote:
> > 2016-10-03 10:38, Olivier Matz:
> >> The file rte_mbuf.h starts to be quite big, and next commits
> >> will introduce more functions related to packet types. Let's
> >> move them in a new file.
> >>
> >> Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>
> >> ---
> >>   lib/librte_mbuf/Makefile         |   2 +-
> >>   lib/librte_mbuf/rte_mbuf.h       | 495 +----------------------------------
> >>   lib/librte_mbuf/rte_mbuf_ptype.h | 552 +++++++++++++++++++++++++++++++++++++++
> >
> > Why not moving packet type and other packet flags in librte_net?
> 
> These are mbuf features.

Yes there is some space reserved in the mbuf for these bits.

> I can reverse the question: why moving them in librte_net? :)

Fair enough :)
I was thinking to group protocol-related definitions in librte_net.
But both approaches are acceptable.

OK to keep the packet types in mbuf lib.