[dpdk-dev] [PATCH] mempool: fix search of maximum contiguous pages

Wei Dai wei.dai at intel.com
Thu Oct 13 11:37:25 CEST 2016


paddr[i] + pg_sz always points to the start physical address of the
2nd page after pddr[i], so only up to 2 pages can be combinded to
be used. With this revision, more than 2 pages can be used.

Fixes: 84121f197187 ("mempool: store memory chunks in a list")

Signed-off-by: Wei Dai <wei.dai at intel.com>
---
 lib/librte_mempool/rte_mempool.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index 71017e1..e3e254a 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -426,9 +426,12 @@ rte_mempool_populate_phys_tab(struct rte_mempool *mp, char *vaddr,
 
 	for (i = 0; i < pg_num && mp->populated_size < mp->size; i += n) {
 
+		phys_addr_t paddr_next;
+		paddr_next = paddr[i] + pg_sz;
+
 		/* populate with the largest group of contiguous pages */
 		for (n = 1; (i + n) < pg_num &&
-			     paddr[i] + pg_sz == paddr[i+n]; n++)
+			     paddr_next == paddr[i+n]; n++, paddr_next += pg_sz)
 			;
 
 		ret = rte_mempool_populate_phys(mp, vaddr + i * pg_sz,
-- 
2.7.4



More information about the dev mailing list