[dpdk-dev] [PATCH v3]virtio:add mtu set in virtio

Dey, Souvik sodey at sonusnet.com
Wed Sep 7 05:45:53 CEST 2016


Hi Liu,


The first version of the patch was reviewed by Stephen and after he agreed I have incorporated all those changes in v2 and v3 had only the style error fixes. That is why I have put the line Reviewed by .
Still I might have some errors in filing the patch as I am new to this. Do you recommend to submit an updated version or this is fine ? 

--
Regards,
Souvik
-----Original Message-----
From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] 
Sent: Tuesday, September 6, 2016 11:38 PM
To: Dey, Souvik <sodey at sonusnet.com>
Cc: dev at dpdk.org; stephen at networkplumber.org
Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio

Firstly, thanks for the patch!

And I got few more style issues for you :) The first goes to the subject (commit summary):

- the prefix is "net/virtio", but not "virtio"

- a space is needed after ':'

On Tue, Sep 06, 2016 at 11:21:56PM -0400, souvikdey33 wrote:
> Signed-off-by: Souvik Dey <sodey at sonusnet.com>

SoB should go the end of the commit log.

> Fixes: 1fb8e8896ca8 ("Signed-off-by: Souvik Dey <sodey at sonusnet.com>")

The fixline is needed for bug fixing patch only. Besides that, the commit has to be an commit has been applied before.

> Reviewed-by: Stephen Hemminger <stephen at networkplumber.org>

I don't see such Reviewed-by from Stephen. I think you should not add it, unless someone has given you that, explicitly.

> Virtio interfaces should also support setting of mtu, as in case of 
> cloud it is expected to have the consistent mtu across the 
> infrastructure that the dhcp server sends and not hardcoded to 1500(default).
> ---
> Corrected few style errors as reported by sys-stv.

It's better to keep old changes, such as:

v3: correct few style errors ...

v2: ....

FYI, you might want to read others patch to get more used to the right way of making a patch.

> 
>  drivers/net/virtio/virtio_ethdev.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.c 
> b/drivers/net/virtio/virtio_ethdev.c
> index 07d6449..da16ad4 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -92,6 +92,7 @@ static void virtio_mac_addr_add(struct rte_eth_dev 
> *dev,  static void virtio_mac_addr_remove(struct rte_eth_dev *dev, 
> uint32_t index);  static void virtio_mac_addr_set(struct rte_eth_dev *dev,
>  				struct ether_addr *mac_addr);
> +static int  virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);

I think it's not necessary if you defined the function before the usage.

	--yliu


More information about the dev mailing list