[dpdk-dev] [PATCH 8/8] net/mlx5: fix inline logic

Ferruh Yigit ferruh.yigit at intel.com
Wed Sep 14 12:43:35 CEST 2016


Hi Nelio,

On 9/7/2016 8:02 AM, Nelio Laranjeiro wrote:
> To improve performance the NIC expects for large packets to have a pointer
> to a cache aligned address, old inline code could break this assumption
> which hurts performance.
> 
> Fixes: 2a66cf378954 ("net/mlx5: support inline send")
> 
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro at 6wind.com>
> Signed-off-by: Vasily Philipov <vasilyf at mellanox.com>
> ---

...

> @@ -607,8 +523,13 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)
>  				MLX5_ETH_WQE_L3_CSUM |
>  				MLX5_ETH_WQE_L4_CSUM;
>  		} else {
> -			wqe->wqe.eseg.cs_flags = 0;
> +			wqe->eseg.cs_flags = 0;

This cause a compilation error, and looks like a typo:

.../drivers/net/mlx5/mlx5_rxtx.c: In function ‘mlx5_tx_burst’:
.../drivers/net/mlx5/mlx5_rxtx.c:526:7: error: ‘volatile union mlx5_wqe’
has no member named ‘eseg’
    wqe->eseg.cs_flags = 0;
       ^~



More information about the dev mailing list