[dpdk-dev] [PATCH v3 1/2] net/vhost: add a new stats struct

Yuanhan Liu yuanhan.liu at linux.intel.com
Tue Sep 20 12:44:27 CEST 2016


On Tue, Sep 20, 2016 at 05:36:44PM +0800, Zhiyong Yang wrote:
> The patch moves all stats counters to a new defined struct vhost_stats
> as follows, in order to manage all stats counters in a unified way and
> simplify the subsequent function implementation(vhost_dev_xstats_reset).
> 
> struct vhost_stats {
> 	uint64_t rx_pkts;
> 	uint64_t tx_pkts;

As I mentioned in last review (you may not notice it though), there is
no need to introduce rx_pkts and tx_pkts: only one of them will be used
for a specific queue. You could just use "pkts".


> 	uint64_t missed_pkts;
> 	uint64_t rx_bytes;
> 	uint64_t tx_bytes;

Ditto.

	--yliu


More information about the dev mailing list