[dpdk-dev] [PATCH] mk: fix verbosity zero

[Thomas Monjalon]

2016-09-23 10:06, Ferruh Yigit:
> On 9/23/2016 12:42 AM, Thomas Monjalon wrote:
> > Verbosity is considered enabled when $V is not empty.
> > So V=0 and V=1 are equivalent.
> > It is fixed by unsetting V when it is 0.
> > 
> > A side effect is to fix kernel module compilation verbosity
> > which is set to 0 when V is empty.
> > 
> > Reported-by: Ferruh Yigit <ferruh.yigit at intel.com>
> > Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
[...]
> > --- a/mk/rte.sdkroot.mk
> > +++ b/mk/rte.sdkroot.mk
> > @@ -34,6 +34,9 @@ MAKEFLAGS += --no-print-directory
> >  # define Q to '@' or not. $(Q) is used to prefix all shell commands to
> >  # be executed silently.
> >  Q=@
> > +ifeq '$V' '0'
> > +override V=
> > +endif
> >  ifdef V
> 
> Why not simply:
> -ifdef V
> +ifeq ($(V),1)

Because:
- V could have a higher value
- $(if $V) construct is used in several places in the makefiles
	See git grep '$(if $(*V'