[dpdk-dev] [PATCH] app/test: fix compilation error when debug mode enabled

Kusztal, ArkadiuszX arkadiuszx.kusztal at intel.com
Tue Sep 27 12:02:16 CEST 2016



> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Monday, September 26, 2016 8:14 PM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal at intel.com>; dev at dpdk.org
> Cc: Trahe, Fiona <fiona.trahe at intel.com>; Jain, Deepak K
> <deepak.k.jain at intel.com>; Griffin, John <john.griffin at intel.com>
> Subject: RE: [PATCH] app/test: fix compilation error when debug mode
> enabled
> 
> Hi Arek,
> 
> > -----Original Message-----
> > From: Kusztal, ArkadiuszX
> > Sent: Monday, September 26, 2016 6:53 AM
> > To: dev at dpdk.org
> > Cc: Trahe, Fiona; Jain, Deepak K; De Lara Guarch, Pablo; Griffin,
> > John; Kusztal, ArkadiuszX
> > Subject: [PATCH] app/test: fix compilation error when debug mode
> > enabled
> >
> > This patch fixes compilation error in test_cryptodev.c when
> > RTE_LOG_DEBUG is specified
> >
> > Fixes: ba0dda7a7100 ("app/test: add GMAC authentication tests to
> > cryptodev
> > tests")
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal at intel.com>
> > ---
> >  app/test/test_cryptodev.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
> > index d744b37..609908b 100644
> > --- a/app/test/test_cryptodev.c
> > +++ b/app/test/test_cryptodev.c
> > @@ -4288,7 +4288,7 @@ static int create_gmac_session(uint8_t dev_id,
> >  	ut_params->cipher_xform.cipher.key.data = cipher_key;
> >  	ut_params->cipher_xform.cipher.key.length = tdata->key.len;
> >
> > -	TEST_HEXDUMP(stdout, "key:", key, key_len);
> > +	TEST_HEXDUMP(stdout, "key:", cipher_key, tdata->key.len);
> >
> >  	ut_params->auth_xform.type = RTE_CRYPTO_SYM_XFORM_AUTH;
> >  	ut_params->auth_xform.next = NULL;
> > @@ -4430,8 +4430,6 @@ test_AES_GMAC_authentication_verify(const
> struct
> > gmac_test_data *tdata)
> >  	TEST_ASSERT_EQUAL(ut_params->op->status,
> > RTE_CRYPTO_OP_STATUS_SUCCESS,
> >  			"crypto op processing failed");
> >
> > -	TEST_HEXDUMP(stdout, "auth tag:", auth_tag, tdata-
> >gmac_tag.len);
> 
> This removal is not related to this fix. If you want to remove it, better to send
> it in another patch.
> 
> Thanks,
> Pablo
> > -
> >  	return 0;
> >
> >  }
> > --
> > 2.1.0
Self Nack - Both lines are removed in different patch


More information about the dev mailing list