[dpdk-dev] [PATCH v7 0/3] net/i40e: configurable PTYPE mapping
Zhang, Qi Z
qi.z.zhang at intel.com
Wed Apr 5 08:01:56 CEST 2017
> -----Original Message-----
> From: Jianbo Liu [mailto:jianbo.liu at linaro.org]
> Sent: Wednesday, April 5, 2017 1:46 PM
> To: Thomas Monjalon <thomas.monjalon at 6wind.com>
> Cc: Zhang, Qi Z <qi.z.zhang at intel.com>; dev at dpdk.org; Yigit, Ferruh
> <ferruh.yigit at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>; Zhang,
> Helin <helin.zhang at intel.com>; Jerin Jacob
> <jerin.jacob at caviumnetworks.com>; Chao Zhu
> <chaozhu at linux.vnet.ibm.com>
> Subject: Re: [dpdk-dev] [PATCH v7 0/3] net/i40e: configurable PTYPE
> On 5 April 2017 at 04:22, Thomas Monjalon <thomas.monjalon at 6wind.com>
> > 2017-04-04 10:30, Ferruh Yigit:
> >> On 4/4/2017 2:55 AM, Qi Zhang wrote:
> >> > The patch set create new APIs that help to change the mapping from
> >> > hardware defined packet type to software defined packet type for i40e
> >> > Keep these APIs private is because currently they are only
> >> > meaningful for devices that support dynamic PTYPE configuration,
> >> > which may not be a general device feature.
> > [...]
> >> > Qi Zhang (3):
> >> > net/i40e: enable per dev PTYPE mapping table
> >> > net/i40e: configurable PTYPE mapping
> >> > app/testpmd: add CL for ptype mapping configure
> >> Series applied to dpdk-next-net/master, thanks.
> > It does not compile for ARM (not tested for POWER):
> > drivers/net/i40e/i40e_rxtx_vec_neon.c: In function
> > 229:2: error: unknown type name 'uint32'
> > uint32 *ptype_tbl = rxq->vsi->adapter->ptype_tbl;
> It must be uint32_t.
> > Given that
> > - it changes NEON and Altivec code
> > - it does not compile on ARM
> > - there is no Ack from NEON or Altivec maintainers (they were
> > not Cc'ed) I really doubt it has been tested.
> > That's why it won't be in RC1.
> > If NEON and Altivec maintainers agree, we can give it a chance for RC2.
> Other than the above error on ARM:
> Acked-by: Jianbo Liu <jianbo.liu at linaro.org>
I will rebase to RC1 and send v8.
Sorry for the inconvenient.
> > PS: please use --in-reply-to to let us check the discussion history.
More information about the dev