[dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit

Thomas Monjalon thomas.monjalon at 6wind.com
Wed Apr 5 10:58:47 CEST 2017


2017-04-05 09:23, Bruce Richardson:
> On Tue, Apr 04, 2017 at 06:12:12PM +0100, Ferruh Yigit wrote:
> > On 4/4/2017 5:36 PM, Allain Legacy wrote:
> > > The AVP devices are only supported on Intel 64-bit architectures so
> > > adjusting the defconfig attributes accordingly.
> > > 
> > > Fixes: c5ab4707ba97 ("net/avp: support driver registration")
> > > 
> > > Signed-off-by: Allain Legacy <allain.legacy at windriver.com>
> > > ---
> > >  config/common_linuxapp                        | 1 -
> > >  config/defconfig_i686-native-linuxapp-gcc     | 5 -----
> > >  config/defconfig_i686-native-linuxapp-icc     | 5 -----
> > >  config/defconfig_x86_64-native-linuxapp-clang | 5 +++++
> > 
> > Right now compiler config files only have compiler and architecture
> > configs, although it is OK to update them, to be consistent with what
> > other PMDs did, what do you think:
> > 
> > Keep AVP config enabled in "common_linuxapp"
> > 
> > Disable AVP in following configs:
> > defconfig_arm64-armv8a-linuxapp-gcc
> > defconfig_arm-armv7a-linuxapp-gcc
> > defconfig_ppc_64-power8-linuxapp-gcc
> > 
> 
> I actually disagree with that, and I think the approach proposed is
> better, given that it's only one target type that is supported.
> 
> However, I think we should have an AVP config option in common base, set
> to "n", so that we at least there have an entry to indicate it exists.

Yes, seems reasonnable


More information about the dev mailing list