[dpdk-dev] [PATCH v2] ether: use a default for max Rx frame size in configure()

Thomas Monjalon thomas.monjalon at 6wind.com
Thu Apr 6 22:48:58 CEST 2017

2017-03-24 12:52, Andriy Berestovskyy:
> At the moment rte_eth_dev_configure() behaves inconsistent:
>  - for normal frames: out of range max_rx_pkt_len uses a default
>  - for jumbo frames: out of range max_rx_pkt_len gives an error
> This patch fixes this inconsistency by using a default value
> for max_rx_pkt_len both for normal and jumbo frames.
> Signed-off-by: Andriy Berestovskyy <Andriy.Berestovskyy at caviumnetworks.com>

It is a bit strange to use the max value when the input is below the minimum.

Anyway, why not fixing it in the reverse way: returning error for
out of range of non-jumbo frames?
I am not sure setting a default value in the back of the caller is really
a good behaviour.

More information about the dev mailing list