[dpdk-dev] [PATCH v2] net/ixgbe: ensure link status is updated

[Ferruh Yigit]

On 4/3/2017 2:23 PM, Laurent Hardy wrote:
> Hi Wei,
> Thanks for your reply.
> 
> If autoneg is false, then we set a default speed to the highest value 
> before performing the link setup.
> You are right, there is no relevant reason to keep this check on speed 
> mask> should be:
> +                       if (!autoneg)
> +                               speed = IXGBE_LINK_SPEED_10GB_FULL;

Hi Laurent,

Should we expect a new version of the patch with above update?

Thanks,
ferruh

> 
> Patch has been tested using testpmd with following setups:
> 
> Autoneg setup:
> =========
> - On dut, both ports of 82599 are connected to a switch with 1Gb ports
> - auto-negotiate option is enabled on switch
> 
> Defined speed setup:
> ============
> - set link speed to 1Gb on both ports of the switch connected to the dut
> 

<...>

> 
> 
> Thanks & regards,
> Laurent
> 
> On 03/30/2017 06:32 PM, Dai, Wei wrote:
>> Hi, Olivier
>>
>> Has anyone already tested this patch ?
>> Can you present some useful info on how to test it ?
>> Can I use ethtool with some argument to downgrade or upgrade the rate of peer port ?
>>
>> I have just run testpmd with 82599, the hw->phy. autoneg_advertised is 0 after rte_eal_init() and rte_eth_dev_start().
>> So I think the codes in if (!speed) { ... } is likely to be run.
>> I agree with most of your codes.
>> But why to limit speed of NIC to 10Gbps if autoneg is false and 10Gbps is supported ?
>> In this case,  how about setting multiple speed ?
>>
>> Thanks
>> -Wei
>>
>>
<...>