[dpdk-dev] [PATCH] app/testpmd: initalize port_numa and ring_numa

Pei, Yulong yulong.pei at intel.com
Fri Apr 28 10:11:28 CEST 2017


Hi Jingjing,

Thanks for the review, already sent v4 patch and fixes line in it.

Best Regards
Yulong Pei

-----Original Message-----
From: Wu, Jingjing 
Sent: Friday, April 28, 2017 3:36 PM
To: Pei, Yulong <yulong.pei at intel.com>; dev at dpdk.org
Cc: Richardson, Bruce <bruce.richardson at intel.com>; thomas at monjalon.net
Subject: RE: [PATCH] app/testpmd: initalize port_numa and ring_numa



> -----Original Message-----
> From: Pei, Yulong
> Sent: Monday, April 24, 2017 3:16 PM
> To: dev at dpdk.org
> Cc: Richardson, Bruce <bruce.richardson at intel.com>; Wu, Jingjing 
> <jingjing.wu at intel.com>; thomas at monjalon.net; Pei, Yulong 
> <yulong.pei at intel.com>
> Subject: [PATCH] app/testpmd: initalize port_numa and ring_numa
> 
> Previous numa_support = 0 by default, it need to add --numa to testpmd 
> command line to enable numa, so port_numa and ring_numa were 
> initalized at function launch_args_parse(), now testpmd change 
> numa_support = 1 as default, so port_numa and ring_numa also need to 
> initalize by default, otherwise port->socket_id will be probed to wrong value.
> 
> Signed-off-by: Yulong Pei <yulong.pei at intel.com>


Thanks!

Patch is fine. Could you add Fixes line for this patch?
I think should be this commit?

commit 999b2ee0fe4511c44462b29566f264e8d9326e1b
Author: Bruce Richardson <bruce.richardson at intel.com>
Date:   Fri Mar 24 17:00:38 2017 +0000

    app/testpmd: enable NUMA support by default

    There is little reason for NUMA support in testpmd to be off by default, so
    enable it, and add in a new commandline parameter to disable it, if that is
    wanted by users.

    Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>


More information about the dev mailing list