[dpdk-dev] [PATCH] doc: update programmer's guide for the GRO library

Mcnamara, John john.mcnamara at intel.com
Thu Aug 3 16:41:50 CEST 2017



> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Friday, July 21, 2017 4:09 PM
> To: Hu, Jiayu <jiayu.hu at intel.com>
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: update programmer's guide for the GRO
> library
> 
> 11/07/2017 06:27, Jiayu Hu:
> > Add description to programmer's guide to explain the design of the GRO
> > library.
> >
> > Signed-off-by: Jiayu Hu <jiayu.hu at intel.com>
> > ---
> >  MAINTAINERS                                        |   1 +
> >  .../prog_guide/generic_receive_offload_lib.rst     | 163
> +++++++++++++++++++++
> >  doc/guides/prog_guide/index.rst                    |   1 +
> >  doc/guides/prog_guide/source_org.rst               |   1 +
> >  4 files changed, 166 insertions(+)
> >  create mode 100644
> > doc/guides/prog_guide/generic_receive_offload_lib.rst
> 
> Looking for a reviewer of this new doc. Any volunteer?


I'll review and reply to Jiayu directly.



 
> > --- a/doc/guides/prog_guide/source_org.rst
> > +++ b/doc/guides/prog_guide/source_org.rst
> > @@ -68,6 +68,7 @@ The lib directory contains::
> >      +-- librte_distributor  # Packet distributor
> >      +-- librte_eal          # Environment abstraction layer
> >      +-- librte_ether        # Generic interface to poll mode driver
> > +    +-- librte_gro          # Generic receive offload library
> >      +-- librte_hash         # Hash library
> >      +-- librte_ip_frag      # IP fragmentation library
> >      +-- librte_kni          # Kernel NIC interface
> 
> I really want we remove this file.
> It is useless and not well maintained.


Agreed. It is guaranteed to be out of date. It could be replaced with a much
shorter and more generic description of the main source dirs without 
mentioning any of the sub-folders or files.

John




More information about the dev mailing list