[dpdk-dev] [PATCH v3] eal/linuxapp: check mmap return value MAP_FAILED

Sergio Gonzalez Monroy sergio.gonzalez.monroy at intel.com
Tue Aug 29 10:31:37 CEST 2017


On 28/08/2017 22:49, Seth Howell wrote:
> If mmap fails, it will return the value MAP_FAILED. Checking for this
> return code allows us to properly identify mmap failures and report
> them as such to the calling function.
>
> Signed-off-by: Seth Howell <seth.howell at intel.com>
> ---
>   lib/librte_eal/linuxapp/eal/eal_memory.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c
> index 5279128..63fec29 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_memory.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
> @@ -716,6 +716,8 @@ create_shared_memory(const char *filename, const size_t mem_size)
>   	}
>   	retval = mmap(NULL, mem_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
>   	close(fd);
> +	if (retval == MAP_FAILED)
> +		return NULL;
>   	return retval;
>   }
>   

Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy at intel.com>



More information about the dev mailing list