[dpdk-dev] [RFC PATCH v4 3/4] eventtimer: add default software implementation stub

[Carrillo, Erik G]

Hi Pavan,

Response in-line:

> -----Original Message-----
> From: Pavan Nikhilesh Bhagavatula
> [mailto:pbhagavatula at caviumnetworks.com]
> Sent: Wednesday, November 29, 2017 4:35 AM
> To: Carrillo, Erik G <erik.g.carrillo at intel.com>
> Cc: dev at dpdk.org; nipun.gupta at nxp.com; hemant.agrawal at nxp.com; Rao,
> Nikhil <nikhil.rao at intel.com>; jerin.jacobkollanukkaran at cavium.com
> Subject: Re: [RFC PATCH v4 3/4] eventtimer: add default software
> implementation stub
> 
> On Tue, Nov 28, 2017 at 11:40:07AM -0600, Erik Gabriel Carrillo wrote:
> > If an eventdev PMD does not wish to provide event timer adapter ops
> > definitions, the library will fall back to a default software
> > implementation whose entry points are added by this commit.
> >
> 
> I do agree with having sw driver in lib/librte_eventdev as it doesn't fit
> anywhere else, but it seems out of place maybe it would be better to
> merged it with rte_event_timer_adapter_driver.h or in
> rte_event_timer_adapter.c as done by eth_rx_adapter.
> 
> Thoughts?

I had also considered merging the SW driver with rte_event_timer_adapter.c but then thought it would be cleaner to separate it into its own module.  

But I'll make the change so that it's more like the eth rx adapter, and if the file gets too messy when we flesh out the SW driver, we can break it back out.

Thanks,
Gabriel

> -Pavan
> 
> > Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo at intel.com>
> > ---
> >  lib/librte_eventdev/Makefile                  |   1 +
> >  lib/librte_eventdev/rte_event_timer_adapter.c |  14 +++
> > lib/librte_eventdev/sw_event_timer_adapter.c  | 123
> > ++++++++++++++++++++++++++
> >  3 files changed, 138 insertions(+)
> >  create mode 100644 lib/librte_eventdev/sw_event_timer_adapter.c