[dpdk-dev] [PATCH 7/7] ethdev: use opaque user callback object

Bruce Richardson bruce.richardson at intel.com
Fri Dec 1 11:33:09 CET 2017


On Fri, Dec 01, 2017 at 02:29:57AM +0000, Ferruh Yigit wrote:
> "struct rte_eth_rxtx_callback" is defined as internal data structure but
> used in public APIs.
> 
> Checking the API documentation shows that intention was using this
> object as opaque object. Data structure only used in delete APIs which
> doesn't require to know the internals of the data structure.
> 
> Converting callback parameter in API to void pointer should not require
> any modification in user application because this data structure was
> already marked as internal and only should be used as pointer in
> application.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ---

I disagree on this patch. The structure itself is not exposed, only the
name, since it is only passed around as a pointer, so there is no need
to change the parameters to void pointer. It's a named opaque type.


More information about the dev mailing list