[dpdk-dev] [PATCH 1/7] ethdev: remove unused flag from header

Vlad Zolotarov vladz at scylladb.com
Fri Dec 1 23:30:31 CET 2017


resending after registering with the new email domain ;)
Please, see my comments below.

On 12/01/2017 05:17 PM, Vlad Zolotarov wrote:
>
>
> On 11/30/2017 09:29 PM, Ferruh Yigit wrote:
>> remove RTE_ETHDEV_HAS_LRO_SUPPORT flag from header.
>>
>> Flag seems added with the patch that adds LRO support, and intention
>> looks like giving a pointer to application that library supports LRO.
>
> Exactly. Removing this flag may make the existing application "think" 
> that LRO is not supported.
> Why do you want to remove it to begin with?
>
>> Fixes: 8eecb3295aed ("ixgbe: add LRO support")
>> Cc:vladz at cloudius-systems.com
>>
>> Signed-off-by: Ferruh Yigit<ferruh.yigit at intel.com>
>> ---
>>   lib/librte_ether/rte_ethdev.h | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
>> index 341c2d624..e620c3706 100644
>> --- a/lib/librte_ether/rte_ethdev.h
>> +++ b/lib/librte_ether/rte_ethdev.h
>> @@ -172,9 +172,6 @@ extern "C" {
>>   
>>   #include <stdint.h>
>>   
>> -/* Use this macro to check if LRO API is supported */
>> -#define RTE_ETHDEV_HAS_LRO_SUPPORT
>> -
>>   #include <rte_log.h>
>>   #include <rte_interrupts.h>
>>   #include <rte_dev.h>
>



More information about the dev mailing list