[dpdk-dev] [PATCH V6 1/3] eal/arm64: remove the braces {} for dmb() and dsb()

Jerin Jacob jerin.jacob at caviumnetworks.com
Sun Dec 3 12:11:16 CET 2017


-----Original Message-----
> Date: Sun, 26 Nov 2017 18:00:22 -0800
> From: Jia He <hejianet at gmail.com>
> To: jerin.jacob at caviumnetworks.com, dev at dpdk.org,
>  bruce.richardson at intel.com, konstantin.ananyev at intel.com
> Cc: olivier.matz at 6wind.com, jianbo.liu at arm.com, hemant.agrawal at nxp.com, Jia
>  He <hejianet at gmail.com>, stable at dpdk.org, Jia He <jia.he at hxt-semitech.com>
> Subject: [PATCH V6 1/3] eal/arm64: remove the braces {} for dmb() and dsb()
> X-Mailer: git-send-email 2.7.4
> 
> for the code as follows:
> if (condition)
> 	rte_smp_rmb();
> else
> 	rte_smp_wmb();
> Without this patch, compiler will report this error:
> error: 'else' without a previous 'if'
> 
> Fixes: 84733fd0d75e ("eal/arm: fix memory barrier definition")
> Cc: stable at dpdk.org
> Signed-off-by: Jia He <jia.he at hxt-semitech.com>

Please fix the below checkpatch errors. 

Wrong tag:
        Suggested-by: Ananyev, Konstantin <konstantin.ananyev at intel.com>
Wrong 'Fixes' reference:
        Fixes: 84733fd0d75e ("eal/arm: fix memory barrier definition")

With above fix:
Acked-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>


More information about the dev mailing list