[dpdk-dev] [PATCH 1/2] event/sw: fix queue memory leak and multi-link bug

[Van Haaren, Harry]

> From: Eads, Gage
> Sent: Thursday, November 30, 2017 3:09 AM
> To: dev at dpdk.org
> Cc: jerin.jacob at caviumnetworks.com; Van Haaren, Harry
> <harry.van.haaren at intel.com>; Richardson, Bruce
> <bruce.richardson at intel.com>; hemant.agrawal at nxp.com; nipun.gupta at nxp.com;
> santosh.shukla at caviumnetworks.com; pbhagavatula at caviumnetworks.com
> Subject: [PATCH 1/2] event/sw: fix queue memory leak and multi-link bug
> 
> This commit reinitializes a queue before it is reconfigured, such that
> reorder buffer memory is not leaked.
> 
> This bug masked a few other problems, which this commit corrects as well:
> - sw_port_link() allowed a port to link to a queue twice, such that the
>   port could then successfully unlink the queue twice. Now the link
>   function checks whether a port is already linked to the queue, and if so
>   returns success but doesn't assign the a port a second slot in the
>   queue's cq map.
> - test_eventdev.c's test_eventdev_unlink() was unlinking a queue twice
>   from the same port, and expecting the second unlink to succeed. Now the
>   test unlinks, links, then unlinks again.
> - test_eventdev.c's test_eventdev_link_get() was linking a single queue but
>   expecting the unlink function to return nb_queues (where nb_queues > 1).
>   The test now checks for a return value of 1.
> 
> Fixes: 5ffb2f142d95 ("event/sw: support event queues")
> Fixes: 371a688fc159 ("event/sw: support linking queues to ports")
> Fixes: f8f9d233ea0e ("test/eventdev: add unit tests")
> 
> Signed-off-by: Gage Eads <gage.eads at intel.com>

Looks good to me,

Acked-by: Harry van Haaren <harry.van.haaren at intel.com>