[dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: add target queues in flow actions

Anoob Joseph anoob.joseph at caviumnetworks.com
Fri Dec 8 17:40:28 CET 2017


HI Nelio,


On 08-12-2017 20:10, Nelio Laranjeiro wrote:
> On Fri, Dec 08, 2017 at 07:30:03PM +0530, Anoob wrote:
>> Hi Nelio,
>>
>>
> [...]
>>> +					goto flow_create;
>>> +				/* Try Queue. */
>>> +				for (i = 0;
>>> +				     i < eth_dev->data->nb_rx_queues; ++i)
>>> +					if (eth_dev->data->rx_queues[i])
>>> +						break;
>> Is the following check correct?
> [...]
>
> For an application, it seems not necessary.  The application knows which
> queues are configured in the drivers has it has made the configuration.
>
> Removing it in the v3.
I think you misunderstood me here.

I was talking about the following line.

+				if (i != eth_dev->data->nb_rx_queues)
+					return -1;

Shouldn't it be?

+				if (i == eth_dev->data->nb_rx_queues)
+					return -1;

Thanks,
Anoob


More information about the dev mailing list