[dpdk-dev] [PATCH v2 1/4] power: changed unsigned to unsigned int

Hunt, David david.hunt at intel.com
Mon Dec 11 11:43:04 CET 2017

Hi Marko,

On 28/11/2017 1:22 PM, Marko Kovacevic wrote:


>   int
> -guest_channel_host_connect(const char *path, unsigned lcore_id)
> +guest_channel_host_connect(const char *path, unsigned int lcore_id)


I'd suggest adding the following into the commit message. It would help 
explain why you're doing all the "unsigned" to "unsigned int" changes up 
front rather than including them in the other patches.

"Since this patch-set attempts to clean up the power library, and there 
are many instances of "unsigned" caught by checkpatch, it was decided to 
clean these up first rather than have them included in the later patches 
in the patch set. And would also minimise this type of error being 
caught by checkpatch in the future."


More information about the dev mailing list