[dpdk-dev] [PATCH] doc: update contribution guideline for dependent work
john.mcnamara at intel.com
Mon Dec 11 15:26:34 CET 2017
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, November 21, 2017 7:59 PM
> To: Thomas Monjalon <thomas at monjalon.net>; Mcnamara, John
> <john.mcnamara at intel.com>
> Cc: dev at dpdk.org; Yigit, Ferruh <ferruh.yigit at intel.com>;
> techboard at dpdk.org
> Subject: [PATCH] doc: update contribution guideline for dependent work
> Changing some part of the libraries but not updating all dependent code
> cause maintenance problems.
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> +* If changes effect other parts of the project, update all those parts as
> well unless updating requires special knowledge.
> + For the cases not all effected code updated, ensure that changes don't
> break existing code.
> * Add tests to the the ``app/test`` unit test framework where possible.
> * Add documentation, if relevant, in the form of Doxygen comments or a
> User Guide in RST format.
Second line would be better as:
For the cases where not all the effected code is updated, the submitter should ensure that changes don't break existing code.
Acked-by: John McNamara <john.mcnamara at intel.com>
More information about the dev